Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build for 'frontend' currently not working because npm is outdated #601

Closed
tommyziegler opened this issue Nov 21, 2022 · 1 comment · Fixed by #605
Closed

Docker build for 'frontend' currently not working because npm is outdated #601

tommyziegler opened this issue Nov 21, 2022 · 1 comment · Fixed by #605
Labels
bug Something isn't working

Comments

@tommyziegler
Copy link
Contributor

Bug Report

The OpenTelemetry demo with Docker does not work because npm is outdated in the base image. I used the current build v1.1.0.

Symptom

The OTel demo app won't start, and I can't access the frontend interface because the container keeps restarting due to an outdated npm dependency.

frontend                 | npm notice 
frontend                 | npm notice New major version of npm available! 8.19.2 -> 9.1.2
frontend                 | npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
frontend                 | npm notice Run `npm install -g npm@9.1.2` to update!
frontend                 | npm notice 
frontend                 | npm ERR! path /app
frontend                 | npm ERR! command failed
frontend                 | npm ERR! signal SIGKILL
frontend                 | npm ERR! command sh -c -- node --require ./Instrumentation.js server.js
frontend                 | 
frontend                 | npm ERR! A complete log of this run can be found in:
frontend                 | npm ERR!     /home/nextjs/.npm/_logs/2022-11-21T14_37_59_716Z-debug-0.log

Reproduce

  1. Download the repo ($git clone)
  2. Try to startup with Docker ($docker compose up)

Additional Context

I used an M1 mac, but I also rebuilt all docker dependencies with the $docker compose command as described in the documentation.

@tommyziegler tommyziegler added the bug Something isn't working label Nov 21, 2022
@tommyziegler
Copy link
Contributor Author

After changing the alpine base image from 16 to 19 on my computer.

src/frontend/Dockerfile:
- FROM node:16-alpine 
+ FROM node:19-alpine

Should and could I create a pull request? What would the process for open telemetry look like?

tommyziegler added a commit to tommyziegler/opentelemetry-demo that referenced this issue Nov 21, 2022
Fix alpine base image since the npm version has a newer major version. See issue: open-telemetry#601
tommyziegler added a commit to tommyziegler/opentelemetry-demo that referenced this issue Nov 24, 2022
Fix the alpine base image since the npm version has a newer major version. Changing to LTS version. See issue: open-telemetry#601
tommyziegler added a commit to tommyziegler/opentelemetry-demo that referenced this issue Nov 26, 2022
Fix the alpine base image since the npm version has a newer major version. Fi to LTS version 18. See issue: open-telemetry#601
puckpuck added a commit that referenced this issue Nov 26, 2022
* Fix 'frontend' currently not working

Fix alpine base image since the npm version has a newer major version. See issue: #601

* Fix 'frontend' currently not working

Fix the alpine base image since the npm version has a newer major version. Changing to LTS version. See issue: #601

* Fix 'frontend' currently not working (to LTS)

Fix the alpine base image since the npm version has a newer major version. Fi to LTS version 18. See issue: #601

Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this issue Mar 22, 2024
* Fix 'frontend' currently not working

Fix alpine base image since the npm version has a newer major version. See issue: open-telemetry#601

* Fix 'frontend' currently not working

Fix the alpine base image since the npm version has a newer major version. Changing to LTS version. See issue: open-telemetry#601

* Fix 'frontend' currently not working (to LTS)

Fix the alpine base image since the npm version has a newer major version. Fi to LTS version 18. See issue: open-telemetry#601

Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant