Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update featureflagservice #1224

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 4, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Update Change
esbuild minor ~> 0.7 -> ~> 0.8
floki minor ~> 0.34.3 -> ~> 0.35.0
gettext minor ~> 0.22 -> ~> 0.23
grpcbox (source) minor ~> 0.16.0 -> ~> 0.17.0
phoenix minor ~> 1.6.16 -> ~> 1.7.0
phoenix_live_view minor ~> 0.17.5 -> ~> 0.20.0

Release Notes

tsloughter/grpcbox (grpcbox)

v0.17.1

Compare Source

v0.17.0

Compare Source


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team November 4, 2023 19:45
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Nov 4, 2023
@austinlparker
Copy link
Member

@open-telemetry/erlang-maintainers @open-telemetry/erlang-approvers could someone look into this build failure?

@tsloughter
Copy link
Member

Pretty sure minor Phoenix releases are basically major ones, hehe, so could be a number of issues in addition to this about not finding the View module.

I'll ping the community to see if someone wants to do the upgrade.

@Tuxified Tuxified mentioned this pull request Nov 7, 2023
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 14, 2023
@tsloughter
Copy link
Member

Saw this was marked stale. Note that #1238 was opened to resolve the build problem.

@github-actions github-actions bot removed the Stale label Nov 15, 2023
* use Phoenix 1.6 style

Phoenix 1.7 has deprecated Phoenix.View in favor
of Phoenix.Component and moved the get_flash
function out of controllers, making us call it
directly

* fix deprecated LV stuff

Some things have changed in LV, these changes
should address that.

- some helpers have moved to Phoenix.Component (live_flash)
- some syntax changes let={f} vs :let={f}
- live_title_tag is now .live_title
Copy link
Contributor Author

renovate bot commented Nov 26, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds and runs fine now.

@austinlparker austinlparker merged commit bf5a0a8 into main Nov 27, 2023
46 checks passed
@austinlparker austinlparker deleted the renovate/featureflagservice branch November 27, 2023 16:56
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* chore(deps): update featureflagservice

* use Phoenix 1.6 style (open-telemetry#1238)

* use Phoenix 1.6 style

Phoenix 1.7 has deprecated Phoenix.View in favor
of Phoenix.Component and moved the get_flash
function out of controllers, making us call it
directly

* fix deprecated LV stuff

Some things have changed in LV, these changes
should address that.

- some helpers have moved to Phoenix.Component (live_flash)
- some syntax changes let={f} vs :let={f}
- live_title_tag is now .live_title

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Tonći Galić <tuxified@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants