-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cartservice] Update to .NET8 #1272
Conversation
983b38e
to
253b053
Compare
@austinlparker, there is a problem while restoring package. (probably the same as on main). Still do not know how to proceed. |
hmm. https://devblogs.microsoft.com/dotnet/improving-multiplatform-container-support/ seems like building on qemu isn't really supported...? i wonder if the stuff in this could help |
fc71e07
to
94050b6
Compare
94050b6
to
58683fc
Compare
@austinlparker, great findings! I do not have the arm64 env. to verify if the build will be working fine. Build logs looks promising. Austin, could you please check the results? @richlander, is there any chance that you review changes in docker build process? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and runs fine. Verified with arm64 (apple).
Also tested locally and it seems to be working. Fingers crossed! |
* [cartservice] Update to .NET8 * Do not install QEMU for .NET * Use BUILDPLATFORM/TARGETARCH
Changes
Update cartservice to .NET8 which is new LTS release.
Replaces #1269
Fixes #1262
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additions[ ] Appropriate documentation updates in the docsN/A[ ] Appropriate Helm chart updates in the helm-chartsN/AMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.