Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cartservice Dockerfile #1308

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Simplify cartservice Dockerfile #1308

merged 1 commit into from
Dec 22, 2023

Conversation

alanwest
Copy link
Member

A number of simplifications to the cartservice Dockerfile.

  1. Per Update samples to .NET 8 dotnet/dotnet-docker#4742, it is an anti-pattern to use msbuild properties in a Dockerfile. The properties are now set in the csproj file.
  2. Removed -c Release from dotnet publish command. As mentioned in this blog post it is now the default.
  3. Simplified determining the runtime identifier. The -r switch now translates linux-musl-amd64 to linux-musl-x64 under the covers. See Enable using docker build --platform switch (easily) dotnet/sdk#30369.

@alanwest alanwest requested a review from a team December 19, 2023 23:02
@puckpuck puckpuck merged commit 43e7a76 into open-telemetry:main Dec 22, 2023
27 checks passed
@alanwest alanwest deleted the alanwest/simplify-cartservice-dockerfile branch January 3, 2024 00:37
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@alanwest
Simplify cartservice Dockerfile (open-telemetry#1308)
9d61b34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mviitane mviitane mviitane approved these changes

@puckpuck puckpuck puckpuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanwest @puckpuck @mviitane