Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache playwright browsers outside root home #1419

Conversation

fvlankvelt
Copy link
Contributor

This allows the loadgenerator to run as non-root user

Changes

The playwright browsers are now cached in /opt, instead of under /root

@fvlankvelt fvlankvelt requested a review from a team February 27, 2024 13:51
@puckpuck
Copy link
Contributor

puckpuck commented Mar 3, 2024

@fvlankvelt, it seems you built this PR from a corporate fork, and we are unable to merge upstream changes because the branch is protected. We typically do not accept PRs from protected branches and request that you do them from your personal forks instead.

This one is ready to be merged, but we need you to take in upstream changes since we can't do it.

@fvlankvelt
Copy link
Contributor Author

@puckpuck : ah, I see. I've created a new PR from a personal fork: #1429

@fvlankvelt fvlankvelt closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants