Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: make stop target for all profiles #1427

Merged
merged 7 commits into from
Mar 7, 2024
Merged

[chore]: make stop target for all profiles #1427

merged 7 commits into from
Mar 7, 2024

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Mar 2, 2024

Changes

Adds --profiles tests,odd to the make stop target so that all profiles supported by the demo are stopped. This is useful if you use the make run-tests or make run-tracetesting; those scenarios will now be properly stopped.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck requested a review from a team March 2, 2024 04:26
@austinlparker austinlparker merged commit c076a66 into open-telemetry:main Mar 7, 2024
26 checks passed
@puckpuck puckpuck deleted the chore.fix-make-stop-target branch March 19, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants