Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(accountingservice): refactor accountingservice dockerfile #1439

Conversation

tranngoclam
Copy link
Contributor

Changes

  • Use golang:1.22-alpine instead of golang:1.22.x-alpine to always get the latest patch version. (i.e: currently golang:1.22-alpine will resolve the go version: 1.22.1 (latest))
  • Use mount type=cache and type=bind from buildkit spec (this is also suggested by command docker init) for better performance when running docker build.
  • Use go list command to install go tools in tools.go with versions locked in go.mod

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@tranngoclam tranngoclam requested a review from a team March 8, 2024 08:24
@austinlparker austinlparker merged commit 6775060 into open-telemetry:main Mar 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants