Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit load generator logs via OTLP #1446

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

austinlparker
Copy link
Member

Changes

fixes #844. load generator now emits logs via OTLP to OpenSearch.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the [docs][]
  • Appropriate Helm chart updates in the [helm-charts][]

@austinlparker austinlparker marked this pull request as ready for review March 11, 2024 18:08
@austinlparker austinlparker requested a review from a team March 11, 2024 18:08
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there is not much being logged.

Should we add more logs to it, or keep it like that?

Also, the logs that are being created are not part of a Trace, hence they do not have TraceID and SpanID attached to them.

@austinlparker
Copy link
Member Author

I think it's fine for now? The logs can't be associated with a trace because they're part of the locust initialization process.

@austinlparker austinlparker merged commit def3a4c into open-telemetry:main Mar 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load Generator should emit structured logs
2 participants