Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adservice add highcpu load ff #1510

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

EislM0203
Copy link
Contributor

@EislM0203 EislM0203 commented Apr 8, 2024

Changes

This PR adds a new featureflag, adServiceHighCpu, to the adservice. When enabled, the adservice uses an abnormal amount of CPU. This is an interesting, real world observability scenario because it simulates high cpu usage problems in the application which afaik no feature flag does this way.

Should you want to demo cpu throttling, you need to add cpu limits to the pod/container in which the adservice is running.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

This commit adds a new ff to the adservice. When enabled, the adservice uses an abnormal amout of CPU.

Should you want to demo cpu throtteling, you need to add cpu limits to the pod/container
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🚀

I liked the result in the chart:
Screenshot 2024-04-10 at 11 39 51

@puckpuck puckpuck merged commit a29c2a7 into open-telemetry:main Apr 11, 2024
28 checks passed
@EislM0203 EislM0203 deleted the adservice-add-highcpu-load-ff branch April 11, 2024 06:17
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
* adservice add highcpu load ff

This commit adds a new ff to the adservice. When enabled, the adservice uses an abnormal amout of CPU.

Should you want to demo cpu throtteling, you need to add cpu limits to the pod/container

* update changelog

---------

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants