-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Global img provider #1571
Merged
julianocosta89
merged 10 commits into
open-telemetry:main
from
klucsik:global-img-provider
May 15, 2024
Merged
[Frontend] Global img provider #1571
julianocosta89
merged 10 commits into
open-telemetry:main
from
klucsik:global-img-provider
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
helm-update-required
Requires an update to the Helm chart when released
label
May 13, 2024
klucsik
force-pushed
the
global-img-provider
branch
from
May 14, 2024 07:49
0360950
to
e8d53db
Compare
klucsik
force-pushed
the
global-img-provider
branch
from
May 14, 2024 09:08
e8d53db
to
3b1f12a
Compare
mviitane
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
julianocosta89
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this @klucsik!
AlexPSplunk
pushed a commit
to splunk/edu-opentelemetry-demo
that referenced
this pull request
Jul 10, 2024
* Add a global image loader * update next to 13.0.0 * remove px from width/hegihts nubmers * bump versions * bump versions * bump versions * remove unecessary spaces * fix distorted iamge, add some extra memory for stability * add changelog * fix checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1570 by moving the image loader to a global scope. This needs a newer next.js version, so some version bumps are also made.
reference on imageloader: https://nextjs.org/docs/pages/api-reference/next-config-js/images
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additions