Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure renovate to bump image deps #1599

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

rogercoll
Copy link
Contributor

Changes

Configures renovate to bump image version defined in the .env file. Although it seems that Renovate is not doing any PR due the PR limit, I reckon we can manually trigger them from its dashboard: #953

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

* [ ] CHANGELOG.md updated to document new feature additions
* [ ] Appropriate documentation updates in the docs
* [ ] Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@rogercoll rogercoll requested a review from a team June 11, 2024 14:26
@puckpuck
Copy link
Contributor

I have some minor concerns here. The OpenSearch and Tracetest images must also be specified in a different location as noted by the comments in the .env file. If we let Renovate update these, it will also need to bump the version in the references noted.

@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Jun 12, 2024
@rogercoll
Copy link
Contributor Author

I have some minor concerns here. The OpenSearch and Tracetest images must also be specified in a different location as noted by the comments in the .env file. If we let Renovate update these, it will also need to bump the version in the references noted.

Good catch! This commit should configure Renovate to bump the inner references too cbef975

Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@puckpuck puckpuck merged commit a61ab14 into open-telemetry:main Jun 13, 2024
29 checks passed
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
* chore: configure renovate to bump image deps

* chore: add tracetest and opensearch to renovate
ahealy-newr pushed a commit to ahealy-newr/opentelemetry-demo-ahealy that referenced this pull request Jul 24, 2024
* chore: configure renovate to bump image deps

* chore: add tracetest and opensearch to renovate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants