-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Valkey] Replace Redis with Valkey #1619
[Valkey] Replace Redis with Valkey #1619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Neat migration 👏
Just opened this PR to update the helm charts: open-telemetry/opentelemetry-helm-charts#1232 (nightly images are failing with helm deployment) |
Edit: please disregard this comment - I think my problem is related to a fork of this repo I am seeing this error locally from the cartservice and it is seemingly unable to start.
Could that be related to this change? |
* replace redis with valkey * changelog --------- Co-authored-by: Mikko Viitanen <74129181+mviitane@users.noreply.github.com>
* replace redis with valkey * changelog --------- Co-authored-by: Mikko Viitanen <74129181+mviitane@users.noreply.github.com>
Changes
This PR replaces Redis with Valkey.
Redis has recently changed its licensing and Valkey was created by the community to continue the project as an Open Source driven project.
Valkey/about:
Linux Foundation Launches Open Source Valkey Community.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.