Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadgenerator service fix bug related to protobuf #173

Merged
merged 7 commits into from
Jun 27, 2022
Merged

loadgenerator service fix bug related to protobuf #173

merged 7 commits into from
Jun 27, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Jun 27, 2022

Fixes #170

Changes

  • Add environment variable to the loadgenerator service in docker-compose.yml to fix bug and force to use python for parsing of protobuf

@mic-max mic-max requested a review from a team June 27, 2022 16:50
@cartersocha
Copy link
Contributor

Lgtm. @mic-max are you looking into anything else or is this the complete PR?

@mic-max
Copy link
Contributor Author

mic-max commented Jun 27, 2022

Lgtm. @mic-max are you looking into anything else or is this the complete PR?

This is it! I'll leave a comment about why this happened

Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha cartersocha merged commit be4c898 into open-telemetry:main Jun 27, 2022
@mic-max mic-max deleted the loadgen-fix branch June 28, 2022 18:08
GaryPWhite pushed a commit to wayfair-contribs/opentelemetry-demo that referenced this pull request Jun 30, 2022
* Update probe version

* Windows-ify paths

* undo health probe version updates

* bug: PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Update probe version

* Windows-ify paths

* undo health probe version updates

* bug: PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoadGenerator service fails to start
3 participants