-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: propagate cartservice exceptions #1744
feat: propagate cartservice exceptions #1744
Conversation
Not sure if this is a local issue, but it seems I assume we have an error on the FF itself. |
Opened #1747 |
@rogercoll, I've done some tests here and I don't see what this PR is actually changing 🤔 |
@julianocosta89 This PR should be propagating the "EmptyCart" error you are sharing in the screenshot but for the GetCart and AddItem transactions/methods. EmptyCart somehow already had it. I have tested this PR in a scenario where the "valkey" database becomes unavailable (Crashloopback in k8s) after some minutes the Demo has started. But the PR is not tied to this specific scenario, in fact, any error that happens downstream those methods will be recorded in the transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for clarifying @rogercoll!
LGTM
Changes
Propagate Grpc expections; the
EmptyCart
method already sets the error in the span, but these two other methods aren't. A common propagated error is when the service cannot establish a connection with the Valkey database.Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additions* [] Appropriate documentation updates in the docs* [ ] Appropriate Helm chart updates in the helm-chartsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.