webstore demo metric enhancement #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
fatsheep9146
changed the title
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
reyang
approved these changes
Jun 28, 2022
|
Could you add a similar to this PR link to the grafana endpoint |
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Absolutely, done. |
mic-max
approved these changes
Jun 28, 2022
|
Thanks for maturing the metrics support @fatsheep9146! |
GaryPWhite
pushed a commit
to wayfair-contribs/opentelemetry-demo
that referenced
this pull request
Jun 30, 2022
* add basic usage of grafana Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * add more config for grafana Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * fix for yamllint Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * fix for yamllint Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * fix for reviews Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
6 tasks
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* add basic usage of grafana Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * add more config for grafana Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * fix for yamllint Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * fix for yamllint Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * fix for reviews Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Following #160, I try to enhance the metrics feature for webstore in several ways:
src/grafana/provisioning/dashboards, I first add a official dashboard for opentelemetry-collector, more dashboards can be added in this folder for example the dashboard for frontend service.For now, this pr is not good enough, I really hope listen to your advises. :-)
Here are some screen shot for grafana, which can be visited in http//:127.0.0.1:3000
Grafana homepage, open without need to login
Prometheus service as datasource, whose name is
webstoreOpentelemetry-collector dashboard
