Makefile does not always use DOCKER_COMPOSE_ENV var
#1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let say that you add a `/src/adservice/Dockerfile.elastic` to the project to build a specific version of the image. So you add the following line to the `.env.override` file: ```env AD_SERVICE_DOCKERFILE=./src/adservice/Dockerfile.elastic ``` If you run: ```sh make redeploy ``` The `/src/adservice/Dockerfile.elastic` should be used instead the default one. This commit adds `DOCKER_COMPOSE_ENV` variable anywhere it's needed. Closes open-telemetry#1758.
rogercoll
approved these changes
Oct 30, 2024
trentm
approved these changes
Oct 30, 2024
|
There's still an error with markdownlinkcheck but I did not change anything ;) |
I think that was a fluke error: the link checker got a 502 for a particular GitHub repo URL during that check. Perhaps @rogercoll could re-run the test (I don't have access to re-run the workflow). |
Correct, rerunning it fixed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Let say that you add a
/src/adservice/Dockerfile.elasticto the project to build a specific version of the image. So you add the following line to the.env.overridefile:If you run:
The
/src/adservice/Dockerfile.elasticshould be used instead of the default one.This commit adds
DOCKER_COMPOSE_ENVvariable anywhere it's needed.Closes #1758.