Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit size of accumulating logs sensibly #238

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

cedricziel
Copy link
Contributor

This change will limit the amount of logs accrueing in docker
to 2 segments à 5M and prevents the demo from flooding the disk
which is useful in long-running demos.

This change will limit the amount of logs accrueing in docker
to 2 segments à 5M and prevents the demo from flooding the disk
which is useful in long-running demos.
@cedricziel cedricziel marked this pull request as ready for review July 27, 2022 12:14
@cedricziel cedricziel requested a review from a team July 27, 2022 12:14
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that!
LGTM!

Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

@cartersocha cartersocha merged commit 013d226 into open-telemetry:main Jul 27, 2022
@cedricziel cedricziel deleted the limit-logging branch August 1, 2022 09:21
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants