Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helm chart to main readme #255

Merged
merged 5 commits into from
Aug 3, 2022
Merged

add helm chart to main readme #255

merged 5 commits into from
Aug 3, 2022

Conversation

cartersocha
Copy link
Contributor

Pointing to our helm chart in our docs

@cartersocha cartersocha requested a review from a team August 3, 2022 17:19
@cartersocha
Copy link
Contributor Author

@wph95 @TylerHelmuth any suggestions on information or doc structure? I tried to adapt the helm repo information & spotlight it

Copy link
Member

@wph95 wph95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start. I think anything more (like common values.yaml options) would be better suited in the chart's readme. I do think it would be good to link directly to https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-demo somewhere in this doc.

README.md Outdated Show resolved Hide resolved
@cartersocha cartersocha merged commit 39d1ee5 into open-telemetry:main Aug 3, 2022
@cartersocha cartersocha deleted the helm-charts branch August 10, 2022 06:47
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* add helm chart

* changelog update

* pr feedback

* nit

* add to prerequisites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants