-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👀 [Frontend] 282 adding initial instrumentation setup #293
👀 [Frontend] 282 adding initial instrumentation setup #293
Conversation
Hey @puckpuck thanks for the review! 😄 I just updated the PR with your comments. Let me know what you think 😄 |
…lemetry-demo into frontend-instrumentation
I'm running your branch and getting several errors in the frontend logs. I'm unable to use the UI to place an order as well.
|
Hey @puckpuck I just updated the PR with a fix for the error you were seeing, we still need to fix the currency service issue but I think that can be done in a separate PR as the problem exists in the main branch. The problem was that we instantiated two zone managers and Next.js already has one. |
@xoscar, now that we fixed the other services, can you update this branch so we have a clean setup to work from? |
@puckpuck done 😃 |
@puckpuck the latest commit I submitted has some fixes for that problem, it should now have the correct root span starting from the client side 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it end to end on my side. Works wonderfully!
@xoscar update this branch & we'll merge next |
@cartersocha Done 😉 |
Did you implement Michael's suggestions? I'm about to resolve the conversations. Also please add a change log entry 😀 |
@cartersocha Yes and Done |
FYI @austinlparker you might want to pull latest for your demo |
Fixes #283.
Changes
Adds the instrumentation code for the front-end application. Changes include:
https://www.loom.com/share/81c1c009c7e3492087ceecf8a0c6f21d
Note
This is just the initial instrumentation wire up, for quality attributes, spans, etc we can have a discussion later on