Render shipping cost nanos in emailservice

[jjatria]

Changes

The template used for the confirmation email in the emailservice did not render the nanos of the shipping cost. This commit adds them, so the rendering of shipping cost and item cost (lower in the template) is equivalent.

This is a minor fix.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jjatria / name: José Joaquín Atria (bd70d8b)

[julianocosta89]

Hello @jjatria, thanks for the contribution.
Is this change actually visible somewhere?
I've rebuilt the service locally, but I couldn't find any difference from the main branch and this PR.

[jjatria]

I don't think it is: the email is being sent through a test transport which as far as I understand does not actually send the email anywhere, it simply stores it for later inspection... which I don't think we do.

I spotted the bug in the code rather than in the output, and if you look back at bc0cd67 to when the original Python version was ported to Ruby, you can see that the original was actually using the nanos in this section. So it just looks like that bit got lost in the port.

Looking at that commit now, it looks like the Ruby version is much less careful about how those numbers are printed, but I chose to keep the diff minimal and simply keep the two uses consistent.

[julianocosta89]

Ah great!
It makes sense.
I've asked because we do have an opened issue in the frontend (#558), where the nanos are also ignored.

[ahayworth]

@jjatria Thanks! I think this was just an oversight from when I initially added the ruby bits (but never noticed because as you pointed out: we don't really send any emails 😆 )

[jjatria]

@ahayworth Makes sense! I only noticed this when I was porting this service to Perl so I could play around locally, and even then only when I noticed I was stringifying a hash instead of a number