-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cart] use 60m TTL for cart cache #779
Merged
cartersocha
merged 6 commits into
open-telemetry:main
from
puckpuck:cart.use_ttl_for_cache
Mar 15, 2023
Merged
[cart] use 60m TTL for cart cache #779
cartersocha
merged 6 commits into
open-telemetry:main
from
puckpuck:cart.use_ttl_for_cache
Mar 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
This one is ready for review, but waiting on #788 to get merged so I can update the changelog |
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
julianocosta89
approved these changes
Mar 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mat-rumian
pushed a commit
to SumoLogic/opentelemetry-demo
that referenced
this pull request
Mar 20, 2023
juliangiuca
pushed a commit
to juliangiuca/opentelemetry-demo
that referenced
this pull request
Apr 12, 2023
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a 60m TTL when items are set in the cart cache (redis). This was done to prevent the memory leak in redis. #771
CHANGELOG.md
updated to document new feature additionsSetting this as a draft PR while doing a multi-day test to ensure memory usage stays level.