Fix to shipping calculation #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a changelog item too! 😎 |
martinkuba
force-pushed
the
shipping-fix
branch
from
b9630d0 to
767a4c0
Compare
cartersocha
approved these changes
Mar 30, 2023
puckpuck
approved these changes
Mar 30, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-demo
that referenced
this pull request
Apr 10, 2023
* Changelog entry for PR 797 (open-telemetry#803) * Changelog entry for PR 797 * Changelog ordered * lint fix * Move Michael Maxwell to Emeritus (open-telemetry#800) Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * Bump actions/stale from 7 to 8 (open-telemetry#804) Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v7...v8) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * use absolute path (open-telemetry#806) Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * use yamllint 1.3.0 (open-telemetry#807) Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [chore] add kubernetes manifest (open-telemetry#791) * add kubernetes manifest Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add kubernetes manifest Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * use absolute path Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * Cart Service - minor cleanup (open-telemetry#801) * Cart Service - minor cleanup * fix file encoding Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com> * [frontend] update JS SDKs (open-telemetry#805) * update JS SDKs Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update JS SDKs for frontend Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * fix formatting Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> Co-authored-by: Austin Parker <austin@ap2.io> * Otlp env variables (open-telemetry#809) * standardize OTEL_* env vars Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * standardize OTEL_* env vars Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * [frontend] fix http.status_code on error (open-telemetry#810) * fix http.status_code on error Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * only end span when synthetic Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * fix http.status_code on error Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * Fix to shipping calculation (open-telemetry#814) * reduce kafka mem allocation (open-telemetry#798) * add kafka mem allocation to changelog (open-telemetry#817) * Changed web tracer to use batch processor (open-telemetry#819) * Updated ENV_PLATFORM flag (open-telemetry#818) * Added elastic's forked opentelemetry demo repo (open-telemetry#813) * Update collector (open-telemetry#822) * use async php runtime (open-telemetry#823) * use async php runtime To better demonstrate PHP's capabilities, use an async runtime (react/http). This means that batch exporters (traces and metrics) are long-lived and more efficient, and they can now use export delays to only send batches after the configured time has elapsed. Update auto-instrumentation extension to install from PECL (the preferred mechanism, which we've just set up), and bump other dependencies to their latest beta versions. * update changelog * Add license check (open-telemetry#825) * adding license check * add/update copyrights * add checklicense to gh checks * add make target to add license * fixup * swap to short form license * add copyright to yaml * and the rest of the yaml * fixup * address comments * fix prometheus scrape bug (open-telemetry#827) Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Austin Parker <austin@ap2.io> * prep for beta (open-telemetry#828) --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Devrim Demiroz <62701796+devrimdemiroz@users.noreply.github.com> Co-authored-by: Reiley Yang <reyang@microsoft.com> Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Austin Parker <austin@ap2.io> Co-authored-by: Martin Kuba <martin@martinkuba.com> Co-authored-by: Bahubali Shetti <billshetti@gmail.com> Co-authored-by: Brett McBride <brett@deakin.edu.au> Co-authored-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
juliangiuca
pushed a commit
to juliangiuca/opentelemetry-demo
that referenced
this pull request
Apr 12, 2023
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes shipping calculation when the Comet Book product is added to the shopping cart. The logical expression was evaluated incorrectly.
Fixes one bug in #327