Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update kubernetes manifest #848

Merged
merged 5 commits into from
Apr 20, 2023
Merged

[chore] update kubernetes manifest #848

merged 5 commits into from
Apr 20, 2023

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Apr 17, 2023

With a Helm chart released for 1.4 of the demo, this is an output of that release. Also forces the namespace to be otel-demo and when combined with a docs change will fix #840

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck requested a review from a team April 17, 2023 21:10
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck changed the title update_kubernetes_manifest [chore] update kubernetes manifest Apr 17, 2023
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck merged commit 5ef82f3 into open-telemetry:main Apr 20, 2023
@puckpuck puckpuck deleted the update_kubernetes_manifest branch April 20, 2023 10:21
AlexanderWert pushed a commit to AlexanderWert/opentelemetry-demo that referenced this pull request Jul 24, 2023
* update k8s manifest to latest

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* update k8s manifest to latest

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* add copyright to generated k8s manifests

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@liuyuanping
Copy link

Hello! I hope you're doing well. I noticed that in your configuration, "tcp-" is added before the service port name instead of "grpc-". For instance, the opentelemetry-demo-paymentservice changes from "service" to "tcp-service".

I observed that in the GoogleCloudPlatform/microservices-demo, it's written as "grpc". Could there be any potential issues if I change it to "grpc-" instead of "tcp-"?

The reason I'm considering this change is that currently, I'm only detecting TCP traffic and not seeing any GRPC traffic in Istio. Your insights on this would be greatly appreciated!

jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* update k8s manifest to latest

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* update k8s manifest to latest

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* add copyright to generated k8s manifests

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubectl command is not creating namespace
3 participants