Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with Azure data explorer demo #910

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

asaharn
Copy link
Contributor

@asaharn asaharn commented Jun 1, 2023

Changes

Added Azure data explorer as featured demo in readme

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@asaharn asaharn requested a review from a team June 1, 2023 05:48
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please maintain alphabetic ordering in the table. Unfortunately, this means changes in several lines.

@mviitane
Copy link
Member

mviitane commented Jun 1, 2023

@asaharn, you could consider waiting for #911 to be merged first to avoid merge conflicts with the table.

@asaharn
Copy link
Contributor Author

asaharn commented Jun 1, 2023

@mviitane I have updated the change

md lint fix
@asaharn
Copy link
Contributor Author

asaharn commented Jun 1, 2023

@cartersocha Thankyou for approving. Can we merge it since all checks are pass.

@cartersocha
Copy link
Contributor

Sure. Thanks for the contribution @asaharn

@cartersocha cartersocha merged commit bb5152c into open-telemetry:main Jun 1, 2023
AlexanderWert pushed a commit to AlexanderWert/opentelemetry-demo that referenced this pull request Jul 24, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants