-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cartservice] Update to .NET 7 #942
Conversation
The cart service is constantly restarting on my mac m2. Getting an error message like " Unhandled exception. System.TypeInitializationException: The type initializer for 'OpenTelemetry.SuppressInstrumentationScope' threw an exception. I can share the more detailed message if needed |
@cartersocha, I was able to reproduce. I am not sure how I missed that while testing (probably I have made mistake while building new docker image). Bug reported under open-telemetry/opentelemetry-dotnet#4600 Locally, I have removed Trimming option. It will increase image size, but it is working correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working now thanks!
@cartersocha, trimming was working on .NET 6 by accident (it is producing warnings). There is a plan to make a support for trimming operation in OpenTelemetry .NET for 1.6 version (tentatively scheduled on November). It should be good to merge for now. |
* [cartservice] Update to .NET 7 * Add changelog entry * Avoid trimming application due open-telemetry/opentelemetry-dotnet#4600
* [cartservice] Update to .NET 7 * Add changelog entry * Avoid trimming application due open-telemetry/opentelemetry-dotnet#4600
Changes
Update target and docker images to .NET7 for cartservice.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additions[ ] Appropriate documentation updates in the docsN/A[ ] Appropriate Helm chart updates in the helm-chartsN/AMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.