-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EventCounters to AotCompatibility.Test #1322
Conversation
This ensures that the OpenTelemetry.Instrumentation.EventCounters library stays AOT-compatible. Contributes to open-telemetry/opentelemetry-dotnet#3429
@eerhardt The AOT workflow does not always run. You would have to change the path here: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/.github/workflows/ci-aot.yml#L6-L8 and also just test the AOT compatibility outside of the workflow to ensure that EventCounters instrumentation is actually AOT-compliant. |
@eerhardt, please take this commit: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1324/commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming GitHub workflow file got updated. Thanks!
I've tested it locally, and it worked. Is there a way to manually kick off the CI leg on this change? @Yun-Ting's Draft PR had these same changes, and the AOT leg passed on it: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/5978918066/job/16221944116 |
@eerhardt You could add a simple |
Thanks for the help! I was able to successfully run the workflow in my fork: |
This ensures that the OpenTelemetry.Instrumentation.EventCounters library stays AOT-compatible.
Contributes to open-telemetry/opentelemetry-dotnet#3429
cc @Yun-Ting