[repo] Fix the solution build in CI to fail if errors are thrown

[CodeBlanch]

nt

[codecov]

Codecov Report

Merging #1487 (7a81f31) into main (71655ce) will decrease coverage by 0.63%.
Report is 95 commits behind head on main.
The diff coverage is 54.44%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1487      +/-   ##
==========================================
- Coverage   73.91%   73.29%   -0.63%     
==========================================
  Files         267      253      -14     
  Lines        9615     9388     -227     
==========================================
- Hits         7107     6881     -226     
+ Misses       2508     2507       -1     

Flag	Coverage Δ
unittests-Exporter.Geneva	57.92% <32.14%> (?)
unittests-Exporter.OneCollector	89.72% <100.00%> (?)
unittests-Extensions	82.75% <100.00%> (?)
unittests-Instrumentation.AspNet	75.96% <ø> (?)
unittests-Instrumentation.EventCounters	75.92% <ø> (?)
unittests-Instrumentation.Owin	85.71% <ø> (?)
unittests-Instrumentation.Process	100.00% <ø> (?)
unittests-Instrumentation.Runtime	100.00% <ø> (?)
unittests-Instrumentation.StackExchangeRedis	71.00% <ø> (?)
unittests-Instrumentation.Wcf	78.47% <ø> (?)
unittests-PersistentStorage	58.80% <ø> (?)
unittests-ResourceDetectors.Azure	80.90% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime	76.08% <ø> (?)
unittests-Solution	80.45% <90.62%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
....Exporter.Geneva/GenevaExporterHelperExtensions.cs	100.00% <ø> (+31.81%)	⬆️
...Telemetry.Exporter.Geneva/GenevaExporterOptions.cs	90.00% <ø> (ø)
...OpenTelemetry.Exporter.Geneva/GenevaLogExporter.cs	85.00% <ø> (+7.50%)	⬆️
...lemetry.Exporter.Geneva/GenevaLoggingExtensions.cs	100.00% <ø> (+14.28%)	⬆️
...enTelemetry.Exporter.Geneva/GenevaTraceExporter.cs	82.50% <ø> (+7.50%)	⬆️
...xporter.Geneva/Internal/ConnectionStringBuilder.cs	92.94% <100.00%> (ø)
...ry.Exporter.Geneva/Internal/ExporterEventSource.cs	14.28% <ø> (+9.52%)	⬆️
...eneva/Internal/ReentrantActivityExportProcessor.cs	100.00% <ø> (ø)
...porter.Geneva/Internal/ReentrantExportProcessor.cs	100.00% <ø> (ø)
...ry.Exporter.Geneva/Internal/TableNameSerializer.cs	98.93% <ø> (ø)
... and 103 more

... and 166 files with indirect coverage changes

[utpilla]

Was this silently failing up until now?

[CodeBlanch]

I think so? I tried to look back at the run where it was introduced to see how it got in initially but detailed logging isn't maintained that far back.

The actual code always sets parentSpanId to default so I'm not sure how it ever ended up something other than what the root has.