[Instrumentation.AspNetCore, Instrumentation.HttpClient] Add Enrichment instructions #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:instrumentation.aspnetcore
cijothomas
reviewed
Sep 10, 2024
| This feature allows you to add custom tags to metrics like `http.server.request.duration`, | ||
| which records the duration of HTTP requests on the server. | ||
|
|
||
| Here's an example of enriching the `http.server.request.duration` metric: |
There was a problem hiding this comment.
where do user specify that they intend to enrich http.server.request.duration metric, and nothing else?
There was a problem hiding this comment.
Fixed in 99a4211
There was a problem hiding this comment.
I am still confused. Where does user specify that they intend to enrich "http.server.request.duration" metric, and nothing else?
The example just shows how to get IHttpMetricsTagsFeature and add tags to it. But don't see any place where user selects which metric is this applied to.
cijothomas
reviewed
Sep 10, 2024
…omchenko/opentelemetry-dotnet-contrib into add-enrichment-instructions
cijothomas
reviewed
Sep 16, 2024
cijothomas
reviewed
Sep 16, 2024
cijothomas
reviewed
Sep 16, 2024
cijothomas
reviewed
Sep 16, 2024
cijothomas
reviewed
Sep 16, 2024
cijothomas
reviewed
Sep 16, 2024
cijothomas
suggested changes
Sep 16, 2024
cijothomas
reviewed
Sep 17, 2024
Kielek
reviewed
Oct 4, 2024
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1762
Changes
Add Enrichment instructions for .NET8.0 for
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes