Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Release request issue template & automation #2080

Merged
merged 18 commits into from
Sep 20, 2024

Conversation

CodeBlanch
Copy link
Member

Changes

  • Adds a new issue template for "Release request" which can be used to initiate a release from an issue

Details

We have a prepare-release workflow with a dispatch trigger which can be used to automate component releases out of this repo. The challenge is only writers/approvers and admins/maintainers can kick that off. Owners of components who do not have at least writer permission cannot use the automation.

What this PR does is add an issue template for requesting a release because... everyone can create issues!

  • If a release request is opened by an approver/writer or maintainer/admin, the bot will automatically kick off the prepare release workflow.

  • If a release request is opened for a component by a user who is listed as an owner of that component in component_owners.yml, the bot will automatically kick off the release workflow.

  • If a release request is opened by a random user, the bot will tag component owners, approvers/writer, and maintainers/admins who may "approve" the process by using a command ("/PrepareRelease").

Here are some test runs:

Note: Need to update RELEASING.md with instructions but I'll do that as a follow-up.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team September 18, 2024 04:58
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (71655ce) to head (78fd12f).
Report is 440 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2080      +/-   ##
==========================================
- Coverage   73.91%   70.07%   -3.85%     
==========================================
  Files         267      332      +65     
  Lines        9615    12942    +3327     
==========================================
+ Hits         7107     9069    +1962     
- Misses       2508     3873    +1365     
Flag Coverage Δ
unittests-Exporter.Geneva 53.32% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 71.24% <ø> (?)
unittests-Exporter.OneCollector 94.32% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 88.57% <ø> (?)
unittests-Extensions.AWS 83.41% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 84.78% <ø> (?)
unittests-Instrumentation.AWSLambda 88.92% <ø> (?)
unittests-Instrumentation.AspNet 76.73% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.12% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 82.06% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 69.92% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-Resources.AWS 77.93% <ø> (?)
unittests-Resources.Azure 82.35% <ø> (?)
unittests-Resources.Container 72.41% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 73.94% <ø> (?)
unittests-Resources.OperatingSystem 77.20% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 77.08% <ø> (?)
unittests-Sampler.AWS 87.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 359 files with indirect coverage changes

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

.github/ISSUE_TEMPLATE/release_request.yml Outdated Show resolved Hide resolved
@CodeBlanch CodeBlanch requested a review from a team as a code owner September 20, 2024 16:21
@CodeBlanch CodeBlanch merged commit c55961c into open-telemetry:main Sep 20, 2024
209 of 213 checks passed
@CodeBlanch CodeBlanch deleted the repo-release-issue branch September 20, 2024 20:43
@CodeBlanch
Copy link
Member Author

Test failures from SQL seem unrelated, merged.

See: #2086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants