Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo] Simplify a couple of MSBuild conditions #2193

Merged
merged 4 commits into from
Oct 9, 2024
Merged

[repo] Simplify a couple of MSBuild conditions #2193

merged 4 commits into from
Oct 9, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

Simplify a couple of MSBuild conditions.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 9, 2024 16:28
@github-actions github-actions bot added comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS labels Oct 9, 2024
@joegoldman2 joegoldman2 marked this pull request as draft October 9, 2024 16:31
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (71655ce) to head (1895a38).
Report is 518 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2193       +/-   ##
===========================================
+ Coverage   73.91%   88.63%   +14.72%     
===========================================
  Files         267       10      -257     
  Lines        9615      176     -9439     
===========================================
- Hits         7107      156     -6951     
+ Misses       2508       20     -2488
Flag Coverage Δ
unittests-Extensions 88.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 267 files with indirect coverage changes

@github-actions github-actions bot removed the comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS label Oct 9, 2024
@joegoldman2
Revert "Revert"
71d17b9 
This reverts commit df57628.
@github-actions github-actions bot added the comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS label Oct 9, 2024
@joegoldman2 joegoldman2 marked this pull request as ready for review October 9, 2024 16:45
CodeBlanch
CodeBlanch approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 03880e5 into open-telemetry:main Oct 9, 2024
53 of 59 checks passed
@joegoldman2 joegoldman2 deleted the simplify-condition branch October 9, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@ppittle ppittle Awaiting requested review from ppittle

@srprash srprash Awaiting requested review from srprash

Assignees

@ppittle ppittle

@srprash srprash

Labels
comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joegoldman2 @CodeBlanch @ppittle @srprash