Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Clean up codecov #2216

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

CodeBlanch
Copy link
Member

Changes

  • Add missing definitions in codecov.yml.
  • Update CI to allow skipping of tests.
  • Skip tests for some "components" which do not produce valid code coverage reports.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team as a code owner October 14, 2024 17:38
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.74%. Comparing base (71655ce) to head (f8d81ea).
Report is 536 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2216      +/-   ##
==========================================
- Coverage   73.91%   71.74%   -2.18%     
==========================================
  Files         267      352      +85     
  Lines        9615    13664    +4049     
==========================================
+ Hits         7107     9803    +2696     
- Misses       2508     3861    +1353     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 87.58% <ø> (?)
unittests-Exporter.Geneva 58.55% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 71.24% <ø> (?)
unittests-Exporter.OneCollector 94.34% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 88.63% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 85.89% <ø> (?)
unittests-Instrumentation.AspNet 76.73% <ø> (?)
unittests-Instrumentation.AspNetCore 70.06% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.12% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 73.57% <ø> (?)
unittests-Instrumentation.Owin 85.97% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 97.53% <ø> (?)
unittests-Instrumentation.SqlClient 90.55% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 69.92% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-Resources.AWS 77.85% <ø> (?)
unittests-Resources.Azure 83.89% <ø> (?)
unittests-Resources.Container 72.41% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 73.94% <ø> (?)
unittests-Resources.OperatingSystem 77.20% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 77.08% <ø> (?)
unittests-Sampler.AWS 87.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 373 files with indirect coverage changes

@Kielek
Copy link
Contributor

Kielek commented Oct 16, 2024

LGTM,
one thing to consider, should the build pipeline/coverage be executed on main branch? At least periodically?
2 reasons:

  • refresh base coverage
  • detect any compilation issues upfront, like new nuget vulnerabilities

@Kielek Kielek merged commit e606128 into open-telemetry:main Oct 16, 2024
127 checks passed
@CodeBlanch CodeBlanch deleted the repo-codecov-cleanup branch October 16, 2024 05:33
@CodeBlanch
Copy link
Member Author

@Kielek You have any experience with codecov UI? I've tried a few times now (this PR included) to make sense of everything but the report just seems stuck in a bad place. Example:

https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/2216?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry

See how it chooses a super old base for comparison? 536 commits behind head 🤣 I was hoping this PR would get that sorted out by refreshing everything (and resolving failed uploads) but looking at subsequent PRs... same mess 🤦

@Kielek
Copy link
Contributor

Kielek commented Oct 16, 2024

I suppose that we need to execute code coverage on main. But I do not have any bigger experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants