Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Clean up SupportedNetTargetsWithoutNet6 #2220

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

CodeBlanch
Copy link
Member

Changes

  • Renames SupportedNetTargetsWithoutNet6 back to SupportedNetTargets

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@github-actions github-actions bot added comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:persistentstorage.abstractions Things related to OpenTelemetry.PersistentStorage.Abstractions comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem comp:resources.aws Things related to OpenTelemetry.Resources.AWS comp:resources.azure Things related to OpenTelemetry.Resources.Azure comp:resources.container Things related to OpenTelemetry.Resources.Container comp:resources.gcp Things related to OpenTelemetry.Resources.Gcp comp:resources.host Things related to OpenTelemetry.Resources.Host comp:resources.operatingsystem Things related to OpenTelemetry.Resources.OperatingSystem comp:resources.process Things related to OpenTelemetry.Resources.Process comp:resources.processruntime Things related to OpenTelemetry.Resources.ProcessRuntime comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS labels Oct 16, 2024
Copy link
Contributor

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very straight forward change.

Can you update the description to mention what's the broader goal you're working towards?
I don't have full context on this change.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.74%. Comparing base (71655ce) to head (3505ef3).
Report is 541 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2220      +/-   ##
==========================================
- Coverage   73.91%   71.74%   -2.18%     
==========================================
  Files         267      357      +90     
  Lines        9615    13756    +4141     
==========================================
+ Hits         7107     9869    +2762     
- Misses       2508     3887    +1379     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 83.17% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 71.24% <ø> (?)
unittests-Exporter.OneCollector 94.34% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 88.63% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 85.89% <ø> (?)
unittests-Instrumentation.AspNet 77.00% <ø> (?)
unittests-Instrumentation.AspNetCore 70.06% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.12% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 57.06% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 73.57% <ø> (?)
unittests-Instrumentation.Owin 85.97% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 97.53% <ø> (?)
unittests-Instrumentation.SqlClient 90.55% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 69.92% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-Resources.AWS 77.85% <ø> (?)
unittests-Resources.Azure 83.89% <ø> (?)
unittests-Resources.Container 72.41% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 73.94% <ø> (?)
unittests-Resources.OperatingSystem 77.20% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 77.08% <ø> (?)
unittests-Sampler.AWS 87.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 377 files with indirect coverage changes

@CodeBlanch
Copy link
Member Author

@TimothyMothra

Can you update the description to mention what's the broader goal you're working towards? I don't have full context on this change.

I'm not working towards anything 🤣

SupportedNetTargetsWithoutNet6 was added by @joegoldman2 as we worked through removing net6.0 from the repo. A whole bunch of PRs went into that.

That effort seems to be done so what this PR is doing is just closing the loop and removing the temporary thing (SupportedNetTargetsWithoutNet6) in favor of the long term thing (SupportedNetTargets).

@CodeBlanch
Copy link
Member Author

Build failures in Geneva are from test project: error NU1902: Package 'MessagePack' 2.5.172 has a known moderate severity vulnerability, GHSA-4qm4-8hg2-g2xm

Going to fix that in a follow-up.

@CodeBlanch CodeBlanch merged commit f6fb714 into open-telemetry:main Oct 18, 2024
123 of 128 checks passed
@CodeBlanch CodeBlanch deleted the repo-net6-cleanup branch October 18, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB comp:exporter.instana Things related to OpenTelemetry.Instrumentation.Instana comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment comp:extensions Things related to OpenTelemetry.Extensions comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda comp:instrumentation.cassandra Things related to OpenTelemetry.Instrumentation.Cassandra comp:instrumentation.confluentkafka Things related to OpenTelemetry.Instrumentation.ConfluentKafka comp:instrumentation.elasticsearchclient Things related to OpenTelemetry.Instrumentation.ElasticsearchClient comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.eventcounters Things related to OpenTelemetry.Instrumentation.EventCounters comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:persistentstorage.abstractions Things related to OpenTelemetry.PersistentStorage.Abstractions comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem comp:resources.aws Things related to OpenTelemetry.Resources.AWS comp:resources.azure Things related to OpenTelemetry.Resources.Azure comp:resources.container Things related to OpenTelemetry.Resources.Container comp:resources.gcp Things related to OpenTelemetry.Resources.Gcp comp:resources.host Things related to OpenTelemetry.Resources.Host comp:resources.operatingsystem Things related to OpenTelemetry.Resources.OperatingSystem comp:resources.process Things related to OpenTelemetry.Resources.Process comp:resources.processruntime Things related to OpenTelemetry.Resources.ProcessRuntime comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS infra Infra work - CI/CD, code coverage, linters perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.