-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Clean up SupportedNetTargetsWithoutNet6 #2220
[repo] Clean up SupportedNetTargetsWithoutNet6 #2220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Very straight forward change.
Can you update the description to mention what's the broader goal you're working towards?
I don't have full context on this change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2220 +/- ##
==========================================
- Coverage 73.91% 71.74% -2.18%
==========================================
Files 267 357 +90
Lines 9615 13756 +4141
==========================================
+ Hits 7107 9869 +2762
- Misses 2508 3887 +1379 Flags with carried forward coverage won't be shown. Click here to find out more. |
I'm not working towards anything 🤣
That effort seems to be done so what this PR is doing is just closing the loop and removing the temporary thing ( |
Build failures in Geneva are from test project: error NU1902: Package 'MessagePack' 2.5.172 has a known moderate severity vulnerability, GHSA-4qm4-8hg2-g2xm Going to fix that in a follow-up. |
Changes
SupportedNetTargetsWithoutNet6
back toSupportedNetTargets
Merge requirement checklist