Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/examples] Prepare to .NET9 #2251

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Oct 28, 2024

.NET 9 brings new set of analyzers.
Analyzers are enabled

<AnalysisLevel>latest-all</AnalysisLevel>
and will be included in pipeline when .NET SDK is updated.

Changes

Fix new warnings by building projects locally with .NET9 SDK RC2

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner October 28, 2024 05:43
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.36%. Comparing base (71655ce) to head (0613530).
Report is 600 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2251       +/-   ##
===========================================
- Coverage   73.91%   61.36%   -12.56%     
===========================================
  Files         267       73      -194     
  Lines        9615     2073     -7542     
===========================================
- Hits         7107     1272     -5835     
+ Misses       2508      801     -1707     
Flag Coverage Δ
unittests-Instrumentation.AspNet 77.00% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.12% <ø> (?)
unittests-Instrumentation.Owin 85.97% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 97.53% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 292 files with indirect coverage changes

@@ -7,12 +7,12 @@ namespace Examples.GrpcCore.AspNetCore.Controllers;

[ApiController]
[Route("[controller]")]
public class WeatherForecastController : ControllerBase
internal class WeatherForecastController : ControllerBase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this. AspNetCore won't auto-register internal controller so this effectively breaks the app. Curious, what is the warning you are getting spurring this change?

Copy link
Contributor Author

@Kielek Kielek Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet format opentelemetry-dotnet-contrib.sln when executing in .NET9 SDK context (I just remove global.json file on my env).

It was one of the reasons to mark is as in progress - the second one, some differences in formatting between .NET8 (CI) and .NET9.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants