-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo/examples] Prepare to .NET9 #2251
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2251 +/- ##
===========================================
- Coverage 73.91% 61.36% -12.56%
===========================================
Files 267 73 -194
Lines 9615 2073 -7542
===========================================
- Hits 7107 1272 -5835
+ Misses 2508 801 -1707
Flags with carried forward coverage won't be shown. Click here to find out more. |
3da8484
to
0613530
Compare
@@ -7,12 +7,12 @@ namespace Examples.GrpcCore.AspNetCore.Controllers; | |||
|
|||
[ApiController] | |||
[Route("[controller]")] | |||
public class WeatherForecastController : ControllerBase | |||
internal class WeatherForecastController : ControllerBase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested this. AspNetCore won't auto-register internal
controller so this effectively breaks the app. Curious, what is the warning you are getting spurring this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotnet format opentelemetry-dotnet-contrib.sln
when executing in .NET9 SDK context (I just remove global.json file on my env).
It was one of the reasons to mark is as in progress - the second one, some differences in formatting between .NET8 (CI) and .NET9.
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
.NET 9 brings new set of analyzers.
Analyzers are enabled
opentelemetry-dotnet-contrib/build/Common.props
Line 13 in cf14a5a
Changes
Fix new warnings by building projects locally with .NET9 SDK RC2
Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)