Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.SqlClient] Metrics documentation #2404

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Dec 10, 2024

Follow up #2309 and @#2311
I need a link to put in AutoInstrumentation doc with available list of metrics.

Changes

[Instrumentation.SqlClient] Metrics documentation
Some minor fix in AspNet documentation (I think that we are lack of url check in CI)

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet documentation Improvements or additions to documentation comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient labels Dec 10, 2024
@Kielek Kielek marked this pull request as ready for review December 10, 2024 07:46
@Kielek Kielek requested a review from a team as a code owner December 10, 2024 07:46
@alanwest alanwest merged commit 01fe660 into open-telemetry:main Dec 11, 2024
53 checks passed
@Kielek Kielek deleted the sqlclient-metrics-documentation branch December 12, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants