Add eval at the end of the instrument script

[dszmigielski]

Why

Instrument script only sets env variables, but does not execute instrumented app.

What

Add eval at the end of the script

[pellared]

Can you describe the use case? Currently the docs instructs to use it to export the needed env vars. Will . instrument.sh still work?

[dszmigielski]

Can you describe the use case? Currently the docs instructs to use it to export the needed env vars. Will . instrument.sh still work?

It seems I was using that in a way it was not supposed to be used. Should I just close it or can it be considered a good change if it doesn't break the previous behaviour (. instrument.sh)?

[pellared]

I prefer closing it. I think "eval" should be avoided. People can always create "subshells" e.g.

dotnet publish -o out
(
  . $HOME/.otel-dotnet-auto/instrument.sh
  export OTEL_SERVICE_NAME=myapp
  export OTEL_RESOURCE_ATTRIBUTES=deployment.environment=staging,service.version=1.0.0
  ./out/myapp
) 

[pjanotti]

We also have a script with the same name under dev/. The run-example.sh script uses the one under dev/ perhaps something to review when doing #1388

Missed @pellared comment about intended usage for this script