-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate examples #1708
Recreate examples #1708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just minor Qs and suggestions.
I agree that the proposed changes makes it simpler for users to execute and instrument the sample app. |
@rajkumar-rangaraj Personally, I would lean towards refactoring the existing We may also merge this PR as it is and you can create a refactor PR if you find it easier.
I would rather use test applications for it 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I glossed over the yml files for the docker-compose and all the config, but everything else looks good to me 👍🏼
Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com>
Why
Fixes #1388
What
Create new example which should be more user-friendly. It works for the latest "non-beta" release.
Check examples/README.md.
I also consider to try adding Grafana Loki as a separate PR.
Tests
Automated test via
make all
and a GitHub workflow to test it in CI.See: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/3624194494/jobs/6110899177
Checklist
CHANGELOG.md
is updated.