Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next-gen] dotnet-monitor design doc #3992

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Jan 29, 2025

Changes

Adding a doc to cover details about the ongoing effort to support out-of-proc monitoring with OTLP egress via dotnet-monitor.

@wiktork, @ramthi FYI

@CodeBlanch CodeBlanch requested a review from a team as a code owner January 29, 2025 06:24
@Kielek
Copy link
Contributor

Kielek commented Jan 29, 2025

I think that we need to add some clarification about supported scenarios (only natively supported libraries/custom diagnostics crated manually by the users). No option to auto-instrument by the bytecode manipulation and/or auto-injecting instrumentation libraries.

I have also some doubts about propagation and sampling. It is not clear to me what will be supported.

@CodeBlanch
Copy link
Member Author

@Kielek Good call. I added a section for Supported scenarios

Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeBlanch Thanks for putting everything together! The documentation is clear and looks good as a starting point. We can refine and enhance it further in future updates.

Copy link
Contributor

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed write-up!

Copy link

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kielek Kielek merged commit 4c370a8 into open-telemetry:main Feb 5, 2025
36 of 38 checks passed
@CodeBlanch CodeBlanch deleted the dotnet-monitor-design-doc branch February 5, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants