Fix histogram for dns.lookup.duration (#5058)

open-telemetry · Nov 16, 2023 · bdd931e · bdd931e
1 parent e904994
commit bdd931e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/OpenTelemetry/Metrics/Metric.cs b/src/OpenTelemetry/Metrics/Metric.cs
@@ -41,7 +41,7 @@ public sealed class Metric
  ("OpenTelemetry.Instrumentation.Http", "http.client.request.duration"),
  ("System.Net.Http", "http.client.request.duration"),
  ("System.Net.Http", "http.client.request.time_in_queue"),
- ("System.Net.NameResolution", "dns.lookups.duration"),
+ ("System.Net.NameResolution", "dns.lookup.duration"),
  };
 
  // Long default histogram bounds. Not based on a standard. May change in the future.

diff --git a/test/OpenTelemetry.Tests/Metrics/AggregatorTestsBase.cs b/test/OpenTelemetry.Tests/Metrics/AggregatorTestsBase.cs
@@ -253,7 +253,7 @@ public void MultiThreadedHistogramUpdateAndSnapShotTest()
  [InlineData("System.Net.Http", "http.client.connection.duration", "s", KnownHistogramBuckets.DefaultLongSeconds)]
  [InlineData("System.Net.Http", "http.client.request.duration", "s", KnownHistogramBuckets.DefaultShortSeconds)]
  [InlineData("System.Net.Http", "http.client.request.time_in_queue", "s", KnownHistogramBuckets.DefaultShortSeconds)]
- [InlineData("System.Net.NameResolution", "dns.lookups.duration", "s", KnownHistogramBuckets.DefaultShortSeconds)]
+ [InlineData("System.Net.NameResolution", "dns.lookup.duration", "s", KnownHistogramBuckets.DefaultShortSeconds)]
  [InlineData("General.App", "simple.alternative.counter", "s", KnownHistogramBuckets.Default)]
  public void HistogramBucketsDefaultUpdatesForSecondsTest(string meterName, string instrumentName, string unit, KnownHistogramBuckets expectedHistogramBuckets)
  {