Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the copyright disclaimer in C# source #4900

Closed
reyang opened this issue Sep 29, 2023 · 5 comments · Fixed by #5140 or open-telemetry/opentelemetry-dotnet-instrumentation#3181
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers infra Infra work - CI/CD, code coverage, linters

Comments

@reyang
Copy link
Member

reyang commented Sep 29, 2023

Feature Request

Currently all *.cs files have very long copyright disclaimer, e.g. https://github.com/open-telemetry/opentelemetry-dotnet/blob/aeca53949a742aa270e9c94d5a53c6a1821a6802/src/Shared/Guard.cs#L1C1-L15C1.

This is the common practice from other OpenTelemetry projects:

https://github.com/open-telemetry/opentelemetry-demo/blob/f44860602656e2313f3cfe6f7e42a464a341786b/src/cartservice/src/Program.cs#L1C1-L2C39

https://github.com/open-telemetry/opentelemetry-cpp/blob/ad626cec4598165e0d297b0bdb3880968c5dfe88/api/include/opentelemetry/config.h#L1-L2

We should consider simplifying copyright info to:

// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
@reyang reyang added enhancement New feature or request help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers infra Infra work - CI/CD, code coverage, linters labels Sep 29, 2023
@reyang
Copy link
Member Author

reyang commented Sep 29, 2023

@MeenuyD
Copy link

MeenuyD commented Sep 29, 2023

Hello @reyang I would like to work on this issue can you please tell me if should I change the copyrights of all the .cs files to the https://github.com/open-telemetry/opentelemetry-demo/blob/f44860602656e2313f3cfe6f7e42a464a341786b/src/cartservice/src/Program.cs#L1C1-L2C39

@reyang
Copy link
Member Author

reyang commented Sep 29, 2023

Hello @reyang I would like to work on this issue can you please tell me if should I change the copyrights of all the .cs files to the https://github.com/open-telemetry/opentelemetry-demo/blob/f44860602656e2313f3cfe6f7e42a464a341786b/src/cartservice/src/Program.cs#L1C1-L2C39

I think YES, and it's okay to send one giant PR.
However, I suggest that we get feedback from @open-telemetry/dotnet-maintainers to see if they are okay with this approach.

@Kielek
Copy link
Contributor

Kielek commented Oct 2, 2023

@MeenuyD
Copy link

MeenuyD commented Oct 2, 2023

Ok I will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers infra Infra work - CI/CD, code coverage, linters
Projects
None yet
3 participants