Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Copyright Disclaimer in *.cs Files #4905

Closed
wants to merge 4 commits into from
Closed

Standardize Copyright Disclaimer in *.cs Files #4905

wants to merge 4 commits into from

Conversation

MeenuyD
Copy link

@MeenuyD MeenuyD commented Sep 29, 2023

In alignment with OpenTelemetry practices (examples https://github.com/open-telemetry/opentelemetry-demo/blob/f44860602656e2313f3cfe6f7e42a464a341786b/src/cartservice/src/Program.cs#L1C1-L2C39 and
https://github.com/open-telemetry/opentelemetry-cpp/blob/ad626cec4598165e0d297b0bdb3880968c5dfe88/api/include/opentelemetry/config.h#L1-L2), simplified the copyright disclaimer in all *.cs files to the format:

// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
This standardizes the copyright information and aligns it with our common practices across OpenTelemetry projects.
#4900

@MeenuyD MeenuyD requested a review from a team September 29, 2023 22:03
@MeenuyD
Copy link
Author

MeenuyD commented Sep 29, 2023

Made changes to standardize the copyright disclaimer in the selected *.cs files. If it meets the project's standards, I am prepared to apply the same changes across all *.cs files upon your approval. The updated format is:


// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

Please review, and I'll proceed accordingly."

@CodeBlanch
Copy link
Member

@MeenuyD This is great! Please continue.

@reyang
Copy link
Member

reyang commented Oct 2, 2023

@MeenuyD FYI, https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/build/stylecop.json needs to be changed to:

{
  "$schema": "https://raw.githubusercontent.com/DotNetAnalyzers/StyleCopAnalyzers/master/StyleCop.Analyzers/StyleCop.Analyzers/Settings/stylecop.schema.json",
  "settings": {
    "documentationRules": {
      "copyrightText": "Copyright The OpenTelemetry Authors\nSPDX-License-Identifier: Apache-2.0",
      "xmlHeader": false
    },
    "orderingRules": {
      "usingDirectivesPlacement": "outsideNamespace"
    }
  }
}

build/stylecop.json Outdated Show resolved Hide resolved
@utpilla
Copy link
Contributor

utpilla commented Oct 4, 2023

@MeenuyD Could you please update the branch and fix the failing tests?

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming all *.cs files will be updated.

@MeenuyD
Copy link
Author

MeenuyD commented Oct 5, 2023

Should I do it now

@reyang
Copy link
Member

reyang commented Oct 5, 2023

Should I do it now

Yes please. Thanks!!!

@MeenuyD
Copy link
Author

MeenuyD commented Oct 6, 2023

Can you please review the #4930

@MeenuyD MeenuyD closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants