Continue Refactoring TracerProvider. #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Aug 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
+ Coverage 76.97% 77.17% +0.20%
==========================================
Files 221 221
Lines 6166 6164 -2
==========================================
+ Hits 4746 4757 +11
+ Misses 1420 1407 -13
|
|
Couple follow ups that can be addressed in separate PRs: |
cijothomas
added a commit
that referenced
this pull request
Aug 11, 2020
* Removing Todos renaming parameter adding tests updating spanbuilderShim updating to internal renaming to spanAttributes solving build issue adding spec reference Continue Refactoring TracerProvider. (#1035) * optimize the flow * fix instrumenataion * move mroe things to provider ctor * move logic arounds Co-authored-by: Reiley Yang <reyang@microsoft.com> changing to class and following spec to replace value replacing from default to null updating package adding xunit.runner renaming method * removing duplicated files * adding some tests and updating to default constructor * removing to be compliant to spec Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1032
Changes
Make "builder" just builder.. Keeps accumulating things to be later used for building the Tracer.
Every other logic is moved to TracerProviderSdk ctor.
Please provide a brief description of the changes here. Update the
CHANGELOG.mdfor non-trivial changes.For significant contributions please make sure you have completed the following items: