Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate JaegerExporter to BatchExportActivityProcessor #1125

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Migrate JaegerExporter to BatchExportActivityProcessor #1125

merged 2 commits into from
Aug 21, 2020

Conversation

eddynaka
Copy link
Contributor

Related to #1078.

Changes

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team August 21, 2020 15:13
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #1125 into master will decrease coverage by 0.23%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
- Coverage   77.57%   77.33%   -0.24%     
==========================================
  Files         222      222              
  Lines        6282     6284       +2     
==========================================
- Hits         4873     4860      -13     
- Misses       1409     1424      +15     
Impacted Files Coverage Δ
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 69.76% <0.00%> (-20.48%) ⬇️
....Exporter.Jaeger/JaegerExporterHelperExtensions.cs 100.00% <100.00%> (ø)
...Exporter.Jaeger/Implementation/JaegerUdpBatcher.cs 86.33% <0.00%> (-5.04%) ⬇️
...us/Implementation/PrometheusExporterEventSource.cs 72.72% <0.00%> (+9.09%) ⬆️

@cijothomas cijothomas merged commit ee5b038 into open-telemetry:master Aug 21, 2020
@eddynaka eddynaka deleted the feature/updating-jaeger-processor branch August 24, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants