Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin/refactor #114

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Zipkin/refactor #114

merged 3 commits into from
Jun 21, 2019

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jun 19, 2019 •
edited
Loading

Goal is to avoid suppressing exceptions in private methods and instead let them fail and suppress only at the public method.

lmolkova
lmolkova approved these changes Jun 19, 2019
View reviewed changes
Copy link

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there was an intention to write different error messages (though EventSource) in catch blocks - which has not been done, but Exception stacktrace should provide enough info once we start logging them

@SergeyKanzhelev SergeyKanzhelev merged commit 27d9b98 into open-telemetry:master Jun 21, 2019
@bruno-garcia bruno-garcia deleted the zipkin/refactor branch June 21, 2019 15:34
@bruno-garcia bruno-garcia mentioned this pull request Oct 2, 2019
Closed
6 tasks
Yun-Ting pushed a commit to Yun-Ting/opentelemetry-dotnet that referenced this pull request Oct 13, 2022
@CodeBlanch
Add ActivityEventAttachingLogProcessor to build ActivityEvents from l…
897b734 
…ogs in OpenTelemetry.Contrib.Preview (open-telemetry#114)

* Added OpenTelemetry.Contrib.Extensions.

* Updated CODEOWNERS.

* README NuGet badge.

* Lint.

* Rename library.

* Added tests.

* Code review.
@dgarciarubio dgarciarubio mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@austinlparker austinlparker Awaiting requested review from austinlparker

@discostu105 discostu105 Awaiting requested review from discostu105

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruno-garcia @lmolkova @SergeyKanzhelev