Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming ParentOrElse to ParentBased #1173

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Renaming ParentOrElse to ParentBased #1173

merged 3 commits into from
Aug 26, 2020

Conversation

eddynaka
Copy link
Contributor

Refs #1143

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team August 26, 2020 17:26
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #1173 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1173      +/-   ##
==========================================
+ Coverage   77.41%   77.44%   +0.03%     
==========================================
  Files         219      219              
  Lines        6261     6261              
==========================================
+ Hits         4847     4849       +2     
+ Misses       1414     1412       -2     
Impacted Files Coverage Δ
src/OpenTelemetry/Trace/ParentBasedSampler.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Trace/TracerProviderBuilder.cs 84.61% <100.00%> (ø)
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️
...us/Implementation/PrometheusExporterEventSource.cs 72.72% <0.00%> (+9.09%) ⬆️

@cijothomas cijothomas merged commit 32fb7c1 into open-telemetry:master Aug 26, 2020
@eddynaka eddynaka deleted the feature/renaming-parentorelse branch August 27, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants