Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming SpanContext to SpanReference #1378

Closed
wants to merge 9 commits into from
Closed

Renaming SpanContext to SpanReference #1378

wants to merge 9 commits into from

Conversation

eddynaka
Copy link
Contributor

Fixes #1377.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team October 21, 2020 00:52
@eddynaka eddynaka self-assigned this Oct 21, 2020
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #1378 into master will decrease coverage by 0.03%.
The diff coverage is 89.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
- Coverage   81.80%   81.77%   -0.04%     
==========================================
  Files         226      226              
  Lines        5991     5991              
==========================================
- Hits         4901     4899       -2     
- Misses       1090     1092       +2     
Impacted Files Coverage Δ
...penTelemetry.Api/Metrics/NoopBoundCounterMetric.cs 0.00% <ø> (ø)
...penTelemetry.Api/Metrics/NoopBoundMeasureMetric.cs 0.00% <ø> (ø)
src/OpenTelemetry.Api/Metrics/NoopCounterMetric.cs 14.28% <ø> (ø)
...enTelemetry/Metrics/DoubleBoundCounterMetricSdk.cs 75.00% <ø> (ø)
...enTelemetry/Metrics/DoubleBoundMeasureMetricSdk.cs 0.00% <ø> (ø)
...penTelemetry/Metrics/Int64BoundCounterMetricSdk.cs 75.00% <ø> (ø)
...penTelemetry/Metrics/Int64BoundMeasureMetricSdk.cs 66.66% <ø> (ø)
src/OpenTelemetry.Api/Metrics/MeasureMetric.cs 25.00% <50.00%> (ø)
...rc/OpenTelemetry/Metrics/DoubleCounterMetricSdk.cs 45.45% <50.00%> (ø)
src/OpenTelemetry/Metrics/Int64CounterMetricSdk.cs 45.45% <50.00%> (ø)
... and 11 more

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eddynaka eddynaka requested a review from cijothomas October 21, 2020 01:39
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise LGTM

@carlosalberto
Copy link

Not an approver here but you may want to hold this, as (it seems) we will stick to SpanContext, as mentioned in the Spec SIG call.

@eddynaka
Copy link
Contributor Author

Not an approver here but you may want to hold this, as (it seems) we will stick to SpanContext, as mentioned in the Spec SIG call.

Oh really? do you have an issue/pr in the spec so we can follow? Thanks for the heads up!

@carlosalberto
Copy link

@eddynaka Yes, I will prepare a PR in a bit (today, that is) ;)

@reyang
Copy link
Member

reyang commented Oct 22, 2020

@eddynaka
Copy link
Contributor Author

Since they reverted, I'm closing this and updating the issue, pointing to the spec reversion.

@eddynaka eddynaka closed this Oct 25, 2020
@eddynaka eddynaka deleted the feature/renaming-spancontext branch October 25, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpanContext to SpanReference in API
6 participants