-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming SpanContext to SpanReference #1378
Renaming SpanContext to SpanReference #1378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment but otherwise LGTM
…ynaka/opentelemetry-dotnet into feature/renaming-spancontext
Not an approver here but you may want to hold this, as (it seems) we will stick to |
Oh really? do you have an issue/pr in the spec so we can follow? Thanks for the heads up! |
@eddynaka Yes, I will prepare a PR in a bit (today, that is) ;) |
Ping back from open-telemetry/opentelemetry-specification#1126 |
Since they reverted, I'm closing this and updating the issue, pointing to the spec reversion. |
Fixes #1377.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes