-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension method to add ConsoleExporter for logs #1452
Merged
cijothomas
merged 6 commits into
open-telemetry:master
from
utpilla:utpilla/Add-ConsoleExporter-ExtensionMethod-ForLogs
Nov 4, 2020
Merged
Add extension method to add ConsoleExporter for logs #1452
cijothomas
merged 6 commits into
open-telemetry:master
from
utpilla:utpilla/Add-ConsoleExporter-ExtensionMethod-ForLogs
Nov 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
utpilla
commented
Nov 4, 2020
- Added an extension method to add ConsoleExporter for logs
- Updated docs/logs/getting-started/Program.cs to use the new extension method to add ConsoleExporter for logs
…e logs getting-started docs to add ConsoleExporter
Codecov Report
@@ Coverage Diff @@
## master #1452 +/- ##
==========================================
- Coverage 81.73% 81.72% -0.02%
==========================================
Files 229 229
Lines 6095 6095
==========================================
- Hits 4982 4981 -1
- Misses 1113 1114 +1
|
reyang
reviewed
Nov 4, 2020
reyang
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cijothomas
approved these changes
Nov 4, 2020
…Exporter-ExtensionMethod-ForLogs
…ttps://github.com/utpilla/opentelemetry-dotnet into utpilla/Add-ConsoleExporter-ExtensionMethod-ForLogs
This was referenced Nov 13, 2020
utpilla
deleted the
utpilla/Add-ConsoleExporter-ExtensionMethod-ForLogs
branch
November 30, 2020 22:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.