Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension method to add ConsoleExporter for logs #1452

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 4, 2020

  • Added an extension method to add ConsoleExporter for logs
  • Updated docs/logs/getting-started/Program.cs to use the new extension method to add ConsoleExporter for logs

…e logs getting-started docs to add ConsoleExporter
@utpilla utpilla requested a review from a team November 4, 2020 03:23
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #1452 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
- Coverage   81.73%   81.72%   -0.02%     
==========================================
  Files         229      229              
  Lines        6095     6095              
==========================================
- Hits         4982     4981       -1     
- Misses       1113     1114       +1     
Impacted Files Coverage Δ
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
....Prometheus/PrometheusExporterMetricsHttpServer.cs 74.50% <0.00%> (-1.97%) ⬇️
...us/Implementation/PrometheusExporterEventSource.cs 72.72% <0.00%> (+9.09%) ⬆️

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit fcde600 into open-telemetry:master Nov 4, 2020
@utpilla utpilla deleted the utpilla/Add-ConsoleExporter-ExtensionMethod-ForLogs branch November 30, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants