Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved SpanHelper to internal #1555

Merged
merged 5 commits into from
Nov 16, 2020
Merged

Moved SpanHelper to internal #1555

merged 5 commits into from
Nov 16, 2020

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 16, 2020

Changes

  • Modified SpanHelper class and ResolveSpanStatusForHttpStatusCode method to internal
  • Updated AspNet, AspNetCore and Http instrumentation projects to add SpanHelper.cs as a link

Addressing #1553

@utpilla utpilla requested a review from a team November 16, 2020 22:45
@codecov
Copy link

codecov bot commented Nov 16, 2020 •
edited
Loading

Codecov Report

Merging #1555 (b180b9d) into master (92ec254) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1555   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files         236      236           
  Lines        6433     6433           
=======================================
  Hits         5210     5210           
  Misses       1223     1223
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Internal/SpanHelper.cs 100.00% <ø> (ø)

@cijothomas cijothomas merged commit 65762cd into open-telemetry:master Nov 16, 2020
CodeBlanch
CodeBlanch reviewed Nov 17, 2020
View reviewed changes
src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md
@@ -5,6 +5,8 @@
* AspNetInstrumentation sets ActivitySource to activities created outside
ActivitySource.
([#1515](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1515/))
* Added SpanHelper class as a link to the the project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in CHANGELOG?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only need in APIs changelog, not in instrumentations. will do a cleanup

@utpilla utpilla mentioned this pull request Nov 18, 2020
Merged
@utpilla utpilla deleted the utpilla/Remove-SpanHelper branch November 30, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch left review comments

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utpilla @cijothomas @CodeBlanch