Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Tests for Logs #1613

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 23, 2020

Changes

  • Added Unit Tests for Logs
  • Update SamplingDecision enum values description to use Activity.Recorded instead of Activity.IsRecorded

@utpilla utpilla requested a review from a team November 23, 2020 22:52
@utpilla utpilla changed the title Utpilla/add unit tests for logs Add Unit Tests for Logs Nov 23, 2020
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #1613 (5caceda) into master (fc8520a) will increase coverage by 1.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
+ Coverage   80.68%   81.82%   +1.14%     
==========================================
  Files         245      245              
  Lines        6575     6575              
==========================================
+ Hits         5305     5380      +75     
+ Misses       1270     1195      -75     
Impacted Files Coverage Δ
...orter.InMemory/InMemoryExporterHelperExtensions.cs 60.00% <0.00%> (+60.00%) ⬆️
.../OpenTelemetry/Logs/OpenTelemetryLoggerProvider.cs 70.45% <0.00%> (+70.45%) ⬆️
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 71.42% <0.00%> (+71.42%) ⬆️
...c/OpenTelemetry/Logs/OpenTelemetryLoggerOptions.cs 80.00% <0.00%> (+80.00%) ⬆️
...enTelemetry/Logs/OpenTelemetryLoggingExtensions.cs 85.71% <0.00%> (+85.71%) ⬆️
src/OpenTelemetry/Logs/LogRecord.cs 87.50% <0.00%> (+87.50%) ⬆️

@cijothomas
Copy link
Member

Thanks for adding test coverage for Logs!

Okay to merge, no product change.

@cijothomas cijothomas merged commit fe9e90d into open-telemetry:master Nov 25, 2020
@utpilla utpilla deleted the utpilla/Add-UnitTests-For-Logs branch November 30, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants