Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in http in and out auto-collectors #162

Merged

Conversation

lmolkova
Copy link

  • special treatment for .NET Core 3.0 (we'll need to set up test infra after 3.0 stable rolls out) - it supports W3C in ASP.NET Core and HttpClient
  • Do not create child Activity for HttpClient
  • Do not set attributes on non-recorded spans
  • Do not instrument outgoing HttpRequests which have 'traceparent' already - something else instrumented them
  • some minor test improvements

@lmolkova lmolkova merged commit 64d9fbf into open-telemetry:master Jul 26, 2019
@lmolkova lmolkova deleted the HttpAutoCollectorsImprovements branch December 19, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants