Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete from Metrics - one file to test #1750 #1751

Merged
merged 7 commits into from
Mar 16, 2021

Conversation

cijothomas
Copy link
Member

PR against Metrics branch.

Only doing one file in this PR to make sure the overall flow is correct.

@cijothomas cijothomas requested a review from a team January 29, 2021 21:10
@cijothomas cijothomas mentioned this pull request Jan 29, 2021
3 tasks
@cijothomas cijothomas closed this Jan 29, 2021
@cijothomas cijothomas reopened this Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #1751 (0c0639b) into metrics (ab278ce) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           metrics    #1751      +/-   ##
===========================================
- Coverage    84.12%   84.11%   -0.02%     
===========================================
  Files          244      244              
  Lines         6824     6824              
===========================================
- Hits          5741     5740       -1     
- Misses        1083     1084       +1     
Impacted Files Coverage Δ
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️

@cijothomas cijothomas merged commit 2660c74 into open-telemetry:metrics Mar 16, 2021
@cijothomas cijothomas deleted the cijothomas/metricsmin1 branch March 16, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants